-
-
Notifications
You must be signed in to change notification settings - Fork 764
Upgrade pants from 2.16.0a0 to 2.16.0rc0 #5950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
33be51c
bump pants to 2.16.0rc0
cognifloyd 778b46c
./pants generate-lockfiles --resolve=pants-plugins
cognifloyd 1ba2328
enhance: use user lockfiles for tools
cognifloyd 196096c
chore: drop unused lockfiles/pylint_plugins.lock
cognifloyd 502345d
chore: regenerate lockfiles for tools
cognifloyd d2ff05b
update changelog entry
cognifloyd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| # This BUILD file has requirements for most of the tools resolves | ||
|
|
||
| python_requirement( | ||
| name="bandit-reqs", | ||
| resolve="bandit", | ||
| requirements=[ | ||
| "bandit==1.7.0", | ||
| "setuptools", | ||
| "GitPython==3.1.18", | ||
| # bandit needs stevedore which needs importlib-metadata<5 | ||
| # see: https://github.com/PyCQA/bandit/pull/952 | ||
| "importlib-metadata<5;python_version<'3.8'", | ||
| ], | ||
| ) | ||
|
|
||
| python_requirement( | ||
| name="black-reqs", | ||
| resolve="black", | ||
| requirements=[ | ||
| "black==22.3.0", | ||
| "typing-extensions>=3.10.0.0;python_version<'3.10'", | ||
| ], | ||
| ) | ||
|
|
||
| python_requirement( | ||
| name="flake8-reqs", | ||
| resolve="flake8", | ||
| requirements=[ | ||
| "flake8==4.0.1", # st2flake8 does not support flake8 v5 | ||
| # license check plugin | ||
| "st2flake8==0.1.0", # TODO: remove in favor of regex-lint or preamble | ||
| ], | ||
| ) | ||
|
|
||
| # for pants-plugins, see //pants-plugins/BUILD | ||
| # for pylint, see //pylint_plugins/BUILD | ||
|
|
||
| python_requirement( | ||
| name="pytest-reqs", | ||
| resolve="pytest", | ||
| requirements=[ | ||
| "pytest==7.0.1", # copied from https://www.pantsbuild.org/v2.14/docs/reference-pytest#version | ||
| "pytest-benchmark[histogram]==3.4.1", | ||
| # "pytest-timer[colorama]", | ||
| "pytest-icdiff", | ||
| "pygments", | ||
| # "pytest-timeout", | ||
| # "pytest-mock", | ||
| "pytest-cov>=2.12,!=2.12.1,<3.1", | ||
| "pytest-xdist>=2.5,<3", | ||
| ], | ||
| ) | ||
|
|
||
| python_requirement( | ||
| name="setuptools-reqs", | ||
| resolve="setuptools", | ||
| requirements=[ | ||
| # setuptools 59.7 (at least) does not support python 3.6 | ||
| "setuptools>=50.3.0,<59.0", | ||
| "wheel>=0.35.1,<0.38", | ||
| ], | ||
| ) | ||
|
|
||
| python_requirement( | ||
| name="twine-reqs", | ||
| resolve="twine", | ||
| requirements=[ | ||
| "twine>=3.7.1,<3.8", | ||
| "colorama>=0.4.3", | ||
| ], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using
BUILD, and as a general rule using only that is good. Pants supportsBUILD.*, and I think it helped to cleanly separate concerns betweenBUILD(for our code) andBUILD.tools(for the tools resolves/requirements).