Skip to content

UI, Tabs as GameObjects #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

baliame
Copy link
Contributor

@baliame baliame commented Mar 9, 2025

Adds SMODS.Tab GameObject. Does nothing on its own, but objectifies tab-based dialog rendering. Implements Run Info and Deck Info as tab groups, allowing mods to add their own tabs quickly.

Additional Info:

  • I didn't modify api's or I've made a PR to the wiki repo.
  • I didn't modify api's or I've updated lsp definitions.
  • I didn't make new lovely files or all new lovely files have appropriate priority.

baliame added a commit to baliame/Wiki that referenced this pull request Mar 9, 2025
@baliame baliame changed the title Info tabs as GameObject UI, Tabs as GameObjects Mar 13, 2025
@baliame
Copy link
Contributor Author

baliame commented Mar 16, 2025

This should be ready for review again, I'm not planning to add more UI classes until someone tells me if we even want this direction.

@english5040
Copy link
Collaborator

Hello- looks like no one's reviewing your PR. I see your PR, it seems that people are just busy.

I definitely like the general idea. I'll take a deeper look when I have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants