Skip to content

Make blind's tag object accessible outside of skipping #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 6, 2025

Conversation

the-Astra
Copy link
Contributor

@the-Astra the-Astra commented Jun 25, 2025

Allows access to a blind's associated tag (if any) via setting_blind context

Additional Info:

  • I didn't modify api's or I've made a PR to the wiki repo.
  • I didn't modify api's or I've updated lsp definitions.
  • I didn't make new lovely files or all new lovely files have appropriate priority.

@the-Astra
Copy link
Contributor Author

Made a wiki PR here Steamodded/Wiki#41

Copy link
Collaborator

@Eremel Eremel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge the global variable once you mark as ready, but I don't feel like it's a relevant value to add to the setting_blind context.

@the-Astra
Copy link
Contributor Author

I do still think in one way or another, having access to a blind’s tag outside of skipping would be useful. Would it be better if I changed this to not include the context and just be the global game variable?

@the-Astra the-Astra changed the title Pass tag object into setting_blind Make blind's tag object accessible outside of skipping Jul 6, 2025
@the-Astra the-Astra marked this pull request as ready for review July 6, 2025 06:54
@the-Astra the-Astra requested a review from Aurelius7309 as a code owner July 6, 2025 06:54
@Eremel Eremel merged commit 54b1412 into Steamodded:main Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants