Feature: When file being edited has unsaved changes, ask for confirmation before closing the edit dialog #3697
Comments
blutorange
pushed a commit
to blutorange/elFinder
that referenced
this issue
Jan 17, 2025
Defaults to false. When set to true, the edit dialog asks the user for confirmation first when they have unsaved changes and attempt to close the dialog. The user can either cancel the operation, keeping the dialog open, discard their changes, or save their changes. Implements Studio-42#3697
|
This issue is stale because it has been open for 50 days with no activity. |
|
Please keep open. |
|
This issue is stale because it has been open for 50 days with no activity. |
|
Please keep open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ElFinder includes many editors for editing files directly within the file explorer. When a file has unsaved changes and the user closes the edit dialog, ElFinder currently first closes the dialog, then asks the user whether they want to save their changes:
confirmAfterClose.webm
We received feedback by our users that this is unintuitive. Instead, ElFinder should keep the dialog open and ask the user whether they want to cancel the operation (keeps the edit dialog open), discard their changes, or save their changes. This is also the behavior of many other text editors. To illustrate, ElFinder should behave like this:
confirmBeforeClose.webm
I'll open a PR for this.
The text was updated successfully, but these errors were encountered: