Support for fonts with multiple descriptors#156
Conversation
chrisellsworth
force-pushed
the
multi-descriptor-fonts
branch
from
9cf9545 to
9a822c7
Compare
|
Perfect, nice one 👌 Could you just please add an entry in the CHANGELOG.md to mention that change and credit yourself? Thanks! |
|
Done. Thanks! Looks like there's now a conflict though. Do you prefer that I rebase my feature branch or make a merge commit, or will you make the merge on your side when pulling in the PR? |
|
If you can rebase your PR on top of |
chrisellsworth
force-pushed
the
multi-descriptor-fonts
branch
from
248ae29 to
03c9fa7
Compare
|
Mmmmh idk what happened with Travis, it seems your rebase didn't properly trigger a new build like it should've. Maybe pushing a dummy new commit might help re-triggering the travis hook?! |
|
|
||
| extension CTFont { | ||
| static func parseFontInfo(fileURL: NSURL) -> Font? { | ||
| static func parseFontInfo(fileURL: NSURL) -> [Font]? { |
There was a problem hiding this comment.
Now that this method returns an array and not a single font, maybe we could return a non-optional array instead (and return an empty array on any guard failure)?
|
Less code, I like it! And so does Travis 👍 |
|
🎉 |
2 participants
I ran into an issue where I tried to use the font "Avenir" which contains descriptors for "Light", "Medium", "Heavy", etc., and the output from
swiftgenonly contained the descriptor for "Book."The intent of this change is to support all of the descriptors from a given font, rather than just the first.