Conversation
djbe
force-pushed
the
feature/github-actions
branch
3 times, most recently
from
df5f8ba to
f29e45a
Compare
djbe
force-pushed
the
feature/github-actions
branch
2 times, most recently
from
cbcec80 to
fb23ea4
Compare
Member
Author
|
Weirdly enough the SPM macOS step is failing here, even though it's working for StencilSwiftKit: https://github.com/SwiftGen/StencilSwiftKit/runs/1305878101?check_suite_focus=true I can't really see a major difference between the 2, except the xcodes = `mdfind "kMDItemCFBundleIdentifier = 'com.apple.dt.Xcode'"`.chomp.split("\n")`In SwiftGen: mdfind_xcodes, _, _ = Open3.capture3('mdfind', "kMDItemCFBundleIdentifier = 'com.apple.dt.Xcode'")
xcodes = mdfind_xcodes.chomp.split("\n")Edit: weeeeird, seems the SSK version fixes it? 😕 @AliSoftware you made this change in 1a12415, any idea what went wrong there? |
|
Hey 👋 I'm Eve, the friendly bot watching over SwiftGen 🤖 Thanks a lot for your contribution! Seems like everything is in order 👍 You did a good job here! 🤝 Generated by 🚫 Danger |
Member
Author
|
Welcome back Eve 🎉 |
djbe
force-pushed
the
feature/github-actions
branch
from
1218852 to
90e5236
Compare
djbe
force-pushed
the
feature/github-actions
branch
from
90e5236 to
f3ca62e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror to SwiftGen/StencilSwiftKit#129, review that first.
@AliSoftware I think you're the only one with access to @SwiftGen-Eve, so you'll probably have to create a new Danger token.