This repository was archived by the owner on Sep 6, 2018. It is now read-only.
Adding a param to customize the access modifier#81
Closed
txaiwieser wants to merge 3 commits intoSwiftGen:masterfrom
txaiwieser:master
Closed
Adding a param to customize the access modifier#81txaiwieser wants to merge 3 commits intoSwiftGen:masterfrom txaiwieser:master
param to customize the access modifier#81txaiwieser wants to merge 3 commits intoSwiftGen:masterfrom
txaiwieser:master
Conversation
Collaborator
|
Nice idea, this looks promising! How about storing the Also, don't forget to:
|
AliSoftware
suggested changes
Oct 1, 2017
Collaborator
There was a problem hiding this comment.
@txaiwieser Ping 😉
Would love to see this go forward. You just need to:
- Replicate the same changes to all the templates (and not just
fonts/swift4) - Add some unit tests for this param (just duplicate another unit test already testing another parameter and change the tested parameter for
accessModifier; you can then use the "Generate fixtures" scheme to generate the expected outputs and have all your tests ready for you) - and last but definitely not least: add a CHANGELOG entry to credit yourself!
2 tasks
Collaborator
|
I've open #84 to supersede this PR with a slight different approach, as it seems this PR went a little stale. |
AliSoftware
added a commit
that referenced
this pull request
Nov 1, 2017
Adding a `param` to customize the access modifier (supersedes #81)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very useful to being able to use SwiftGen from inside a framework. And use the generated code in the main target.