Skip to content

ST6RI-807 Flow Connection Revision (SYSML2_-173) #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Conversation

seidewitz
Copy link
Member

This PR implements the resolution for the following issue approved on SysML v2 FTF 2 Ballot 5:

  • SYSML2_-173 Flow connections are incorrectly both structure and behavior

This resolution updates the SysML v2 abstract syntax so that FlowConnectionDefinitions are no longer kinds of ConnectionDefinitions and FlowConnectionUsages are no longer kinds of ConnectionUsages. In particular, this means that FlowConnectionUsages are no longer PartUsages, so they no longer are included in the ownedParts of a Definition or the nestedParts of a Usage (they are still included in ownedConnections and nestedConnections). The resolution also moves the base types for FlowConnectionDefinitions and FlowConnectionUsages out of the Systems Library model Connections into a new model FlowConnections. The textual and graphical notation for flows is unaffected.

(Metamodel also reflects corrections in ordering of subsettings for
some key Definition and Usage attributes.)

- Updated FlowConnectionDefinitionAdapter and
FlowConnectionUsageAdapter.

- Updated setting delegates for FlowConnectionDefinition and
FlowConnectionUsage.
- Updated implicit generalization mapping for flow connections.
- Updated SysML Xpect tests.
- Updated SysML semantics tests.
@seidewitz seidewitz self-assigned this Dec 20, 2024
@seidewitz seidewitz added this to the 2024-12 milestone Dec 20, 2024
@seidewitz seidewitz requested review from himi and ujhelyiz December 20, 2024 04:44
@seidewitz
Copy link
Member Author

@himi
Please confirm that this update does not affect the visualization of flows.

@ujhelyiz
Note that the semantics tests have been updated to account for the abstract syntax and model library changes.

Copy link
Contributor

@ujhelyiz ujhelyiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the changes look good to me. However, I have found a minor issue with a comment and have a question about the changes in the SysML grammar. However, I consider neither of these as blocking issues.

@himi
Copy link
Member

himi commented Dec 20, 2024

I found 17b-Sequence-Modeling did not seem to be visualized in 'Sequence' view. I will look into it. (Note that 17a-Sequence-Modeling worked properly)

I confirmed master trunk did not have this issue.

Sorry, it seemed that I did not refresh the library and clean the index properly

Copy link
Member

@himi himi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fully cleaned and rebuilt the model libraries, I confirmed the visualizer worked correctly.

@seidewitz seidewitz merged commit 967ce0c into master Dec 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants