-
Notifications
You must be signed in to change notification settings - Fork 34
ST6RI-807 Flow Connection Revision (SYSML2_-173) #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(Metamodel also reflects corrections in ordering of subsettings for some key Definition and Usage attributes.) - Updated FlowConnectionDefinitionAdapter and FlowConnectionUsageAdapter. - Updated setting delegates for FlowConnectionDefinition and FlowConnectionUsage.
- Updated implicit generalization mapping for flow connections. - Updated SysML Xpect tests. - Updated SysML semantics tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, the changes look good to me. However, I have found a minor issue with a comment and have a question about the changes in the SysML grammar. However, I consider neither of these as blocking issues.
org.omg.sysml/src/org/omg/sysml/adapter/FlowConnectionUsageAdapter.java
Outdated
Show resolved
Hide resolved
Sorry, it seemed that I did not refresh the library and clean the index properly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fully cleaned and rebuilt the model libraries, I confirmed the visualizer worked correctly.
This PR implements the resolution for the following issue approved on SysML v2 FTF 2 Ballot 5:
This resolution updates the SysML v2 abstract syntax so that
FlowConnectionDefinitions
are no longer kinds ofConnectionDefinitions
andFlowConnectionUsages
are no longer kinds ofConnectionUsages
. In particular, this means thatFlowConnectionUsages
are no longerPartUsages
, so they no longer are included in theownedParts
of aDefinition
or thenestedParts
of aUsage
(they are still included inownedConnections
andnestedConnections
). The resolution also moves the base types forFlowConnectionDefinitions
andFlowConnectionUsages
out of the Systems Library modelConnections
into a new modelFlowConnections
. The textual and graphical notation for flows is unaffected.