Skip to content

Added polymorphism test and virtual functions #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mondus
Copy link

@mondus mondus commented May 15, 2024

Pull request fixes #2278 by making Writer class functions virtual to allow correct behaviour when PrettyWriter is cast to the base class.

Changes made

  • Unit Test which ensures that PrettyWriter maintains pretty writing when cast to Writer
  • Changes to Writer class functions to make them virtual

@tencent-adm
Copy link
Member

tencent-adm commented May 15, 2024

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polymorphism not used for PrettyWriter
2 participants