Add stream position check to reader unit tests #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| streamPos = 6; // 0xF0 - 0xF4 | ||
| else | ||
| streamPos = 3; // 0xF5 - 0xFF | ||
| TEST_STRING_ERROR(kParseErrorStringInvalidEncoding, e, 2, streamPos); |
There was a problem hiding this comment.
The values for streamPos assigned above look a bit odd, they do not exactly match to section 3.2 of http://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-test.txt
There was a problem hiding this comment.
It matches https://en.wikipedia.org/wiki/UTF-8#Codepage_layout though. If it's on Wikipedia it must be true :)
miloyip
added a commit
that referenced
this pull request
Feb 13, 2016
Add stream position check to reader unit tests
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some checks to the reader unit tests, to make sure the amount of characters read from the input stream is as expected.
I've simply used the current amount of read characters, to make the tests pass.