Skip to content

Conversation

@marsonya
Copy link
Contributor

@marsonya marsonya commented Oct 9, 2020

Here are the changes I made in the Sorts/BubbleSort.js file:

  • Added Wikipedia Link.
  • Improved Comments and Formatting.
  • The first BubbleSort (using 2 for loops) was not returning the array. Changed that.
  • Improved the Implementation Examples and Console logs.
  • And Finally, added doctests as mentioned in (Issue #142)
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not

@marsonya
Copy link
Contributor Author

marsonya commented Oct 9, 2020

Hey @itsvinayak @cclauss
I have improved the BubbleSort and added doctests.
Kindly let me know if the doctests are okay and merge the changes.
I would like to go ahead and add doctests to other files.
Thanks.

Copy link
Member

@itsvinayak itsvinayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @marsonya

@itsvinayak itsvinayak merged commit 01de729 into TheAlgorithms:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants