NATIVE_WRITE_FAILED Error on Windows 10

[davidofwatkins]

On Windows 10 (Surface Pro), I'm getting a NATIVE_WRITE_FAILED error from the following code:

NativeStorage.setItem('foo', 'bar', function() {
    console.log('success');
},
function(err) {
    console.log('error', err); // err = { code: 1, exception: null, source: "Native" }
});

In the "Output" tab of Visual Studio, I see the following when I run this:

The maximum number of credentials that may be stored has been exceeded
WinRT information: The maximum number of credentials that may be stored has been exceeded

I don't have much experience developing for Windows, but I see that NativeStorage is saving to Windows.Security.Credentials.PasswordVault() on Windows (see #38), which seems too limited to me. Is this expected? Perhaps the plugin should use something like Windows.Storage.ApplicationData?

Does anyone have any further ideas how to fix this? (cc @3h3c)

[alokrajiv]

@davidofwatkins Thank you very much for bringing this into notice.

I am going to re-write the windows implementation usingWindows.Storage.ApplicationData.current.localSettings.

[julesongithub]

@alokrajiv I don't know how to use github but I've got the code to replace the Windows.Security.Credentials.PasswordVault functionality with Windows.Storage.ApplicationData.current.localSettings:

var NativeStorageProxy = {
    getItem: function (win, fail, args) {
        try {
            var key = args[0];
            var value = Windows.Storage.ApplicationData.current.localSettings.values[key];
            // A value of undefined will throw a JSON error during the win() callback
            if (value === undefined) {
                fail(2);
            }
            else {
                win(value);
            }
        } catch (e) {
            fail(2);
        }
    },
    setItem: function (win, fail, args) {
        try {
            var key = args[0],
                value = args[1];
            // A value of undefined will throw a JSON error during the win() callback
            if (value === undefined) {
                fail(3);
            }
            else {
                Windows.Storage.ApplicationData.current.localSettings.values[key] = value;
                win(value);
            }
        } catch (e) {
            fail(1);
        }
    },
    remove: function (win, fail, args) {
        try {
            var values = Windows.Storage.ApplicationData.current.localSettings.values,
                key = args[0];
            if (values.hasKey(key)) {
                values.remove(key);
                win(key);
            }
            else {
                fail(2);
            }
        } catch (e) {
            fail(1);
        }
    },
    clear: function (win, fail, args) {
        try {
            Windows.Storage.ApplicationData.current.localSettings.values.clear();
            win();
        } catch (e) {
            fail(1);
        }
    },
    keys: function (win, fail) {
        try {
            var values = Windows.Storage.ApplicationData.current.localSettings.values,
                keys = [];
            for (var p in values) {
                if (values.hasOwnProperty(p)) {
                    keys.push(p);
                }
            }
            win(keys);
        } catch (e) {
            fail(2);
        }
    },
    putString: function (win, fail, args) {
        this.setItem(win, fail, args);
    },
    getString: function (win, fail, args) {
        this.getItem(win, fail, args);
    },
    putBoolean: function (win, fail, args) {
        this.setItem(win, fail, args);
    },
    getBoolean: function (win, fail, args) {
        this.getItem(win, fail, args);
    },
    putInt: function (win, fail, args) {
        this.setItem(win, fail, args);
    },
    getInt: function (win, fail, args) {
        this.getItem(win, fail, args);
    },
    putDouble: function (win, fail, args) {
        this.setItem(win, fail, args);
    },
    getDouble: function (win, fail, args) {
        this.getItem(win, fail, args);
    }
};

require("cordova/exec/proxy").add("NativeStorage", NativeStorageProxy);

[JeffBerman]

Has this been looked into at all, or has @julesongithub's code been reviewed? We just got bit by the same NATIVE_WRITE_FAILED error on a Windows 10 Surface Pro.

[alokrajiv]

Unfortunately, something I missed along the way. Maybe someone can contribute here?