chore(caching): add initial caching example #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/caching/src/index.js
Outdated
| var element = document.createElement('div'); | ||
|
|
||
| // Lodash, currently included via a script, is required for this line to work | ||
| // Lodash, now imported by this script |
There was a problem hiding this comment.
I think it's either one of these comments, not both :)
|
Just check the Travis log, some minor whitspace and semi-colon stuff |
|
Bang bang! All three PRs passing 🎉 -- and yeah once we decide to start linking these from the actual guides we should do a final review to make sure they line up correctly. We'll also have to make sure any updates to the code in the guides are also reflected here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new caching test project I created while writing webpack/webpack.js.org#1436. This may still need some updates once that PR is reviewed.
Also I ignored
distdirectories in the main.gitignore-- I couldn't think of a reason to keep manage those directories in the repo as they are auto-generated but if there is, please let me know.