Skip to content

Added the Hello World Article for Emojicode. #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2020
Merged

Added the Hello World Article for Emojicode. #320

merged 2 commits into from
Oct 1, 2020

Conversation

Bracciata
Copy link
Contributor

Issue #247

@jrg94 jrg94 requested a review from a team October 1, 2020 02:32
@jrg94 jrg94 self-assigned this Oct 1, 2020
@jrg94 jrg94 added the sample program Sample program documentation label Oct 1, 2020
jrg94
jrg94 requested changes Oct 1, 2020
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'd just double check the author tag here.

Bracciata
Bracciata commented Oct 1, 2020
View reviewed changes
Copy link
Contributor Author

@Bracciata Bracciata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed them in my latest commit. Thanks for catching that.

jrg94
jrg94 approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrg94 jrg94 merged commit d1ba573 into TheRenegadeCoder:master Oct 1, 2020
@Bracciata
Copy link
Contributor Author

Bracciata commented Oct 3, 2020 •
edited
Loading

@jrg94 can you mark this and my other pull requests with the topic hacktoberfest-accepted. Thank you! Also if you would like me to ping you on those two just let me know!
EDIT: nevermind. Sorry about the ping. My prs follow the old rules.

@jrg94
Copy link
Member

jrg94 commented Oct 3, 2020

I'm not sure what rules you're referring too, but I did this yesterday: https://twitter.com/hacktoberfest/status/1312221208667185153?s=20

I assume all your pull requests should be good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrg94 jrg94 jrg94 approved these changes

Assignees

@jrg94 jrg94

Labels
sample program Sample program documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bracciata @jrg94