Skip to content

Added Pull Request Template #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 8, 2020
Merged

Conversation

UdokaVrede
Copy link
Contributor

This P.R fixes issue number #315

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really cool idea! Since this is a repo mostly for articles, I don't know that some of this stuff applies. What do you think?

@jrg94 jrg94 added the enhancement New feature or request label Oct 5, 2020
@jrg94 jrg94 self-assigned this Oct 5, 2020
@UdokaVrede
Copy link
Contributor Author

oh right I would fix this now

@jrg94
Copy link
Member

jrg94 commented Oct 7, 2020

I added some new stuff to the main README. Perhaps this could help: https://github.com/TheRenegadeCoder/sample-programs-website/blob/master/README.md

@UdokaVrede
Copy link
Contributor Author

Alright

@UdokaVrede
Copy link
Contributor Author

Can you give some more details pls

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better! I think we can more or less just use this check list. Everything else can probably be removed. 👍

[ ] Other


For a guide, on making your pull request, see [Pull_Request](https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For a guide, on making your pull request, see [Pull_Request](https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request)

What kind of change does this PR introduce?
```
[ ] Sample program
[ ] Language Documentation content
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[ ] Language Documentation content
- [ ] Language Documentation

```
[ ] Sample program
[ ] Language Documentation content
[ ] Project Documentation content
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[ ] Project Documentation content
- [ ] Project Documentation

## PR Type
What kind of change does this PR introduce?
```
[ ] Sample program
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[ ] Sample program
- [ ] Sample Program Documentation

@jrg94 jrg94 changed the title Added Pull_request_template.md Added Pull Request Template Oct 7, 2020
Copy link
Contributor Author

@UdokaVrede UdokaVrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks

@jrg94 jrg94 linked an issue Oct 8, 2020 that may be closed by this pull request
@jrg94 jrg94 merged commit e33270b into TheRenegadeCoder:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Pull Request Template
2 participants