-
-
Notifications
You must be signed in to change notification settings - Fork 27
Added Pull Request Template #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really cool idea! Since this is a repo mostly for articles, I don't know that some of this stuff applies. What do you think?
oh right I would fix this now |
I added some new stuff to the main README. Perhaps this could help: https://github.com/TheRenegadeCoder/sample-programs-website/blob/master/README.md |
Alright |
Can you give some more details pls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better! I think we can more or less just use this check list. Everything else can probably be removed. 👍
pull_request_template.md
Outdated
[ ] Other | ||
|
||
|
||
For a guide, on making your pull request, see [Pull_Request](https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a guide, on making your pull request, see [Pull_Request](https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request) |
pull_request_template.md
Outdated
What kind of change does this PR introduce? | ||
``` | ||
[ ] Sample program | ||
[ ] Language Documentation content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ ] Language Documentation content | |
- [ ] Language Documentation |
pull_request_template.md
Outdated
``` | ||
[ ] Sample program | ||
[ ] Language Documentation content | ||
[ ] Project Documentation content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ ] Project Documentation content | |
- [ ] Project Documentation |
pull_request_template.md
Outdated
## PR Type | ||
What kind of change does this PR introduce? | ||
``` | ||
[ ] Sample program |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ ] Sample program | |
- [ ] Sample Program Documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks
This P.R fixes issue number #315