-
-
Notifications
You must be signed in to change notification settings - Fork 27
Added Transpose Matrix in Every Language Article #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Docs for transpose matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! It would be cool if you could come up with a table for testing, so we can see what sort of input/output you're expecting.
Yeah sorry didn't notice the first time. Updated now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is the matrix meant to be input on the command line?
The program asks for the input of m and n to create an m*n matrix and then while entering the values the input line mentions for which i^th and j^th position the user is entering the values. |
Oh I see! Typically, in this repo, we want input to be entered on the command line. For example, if this were a python program, I would expect to be able to do the following: I'm not sure what the best way would be to do this, but perhaps you could enter each row as a list:
|
Yeah depending on the value of m and n in the m*n matrix it will automatically identify. |
Agreed! But, we want the program to pull directly from the command line arguments—not from standard input. |
So it will generally be set for a square matrix say 3*3 so the input will consist of 9 numbers
|
Okay, so this won't work for any size matrix? |
It will but it's difficult to say on command line arguments unless the size of the matrix is also given in command line. |
For sure! But, our repo depends on this script to be able to work through the command line. So, there should be some way to represent the input. I'm thinking there are probably two ways:
Perhaps there are other options that are cleaner. |
I think the first option works here. There could be other methods but they dont satisfy the need if variable matrix. |
Perfect! Any chance you can rework the docs to run off this new setup? |
Yeah updated the docs. Check if it works? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a couple more changes, and we'll be good to go.
Co-authored-by: Jeremy Grifski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Almost there. Just a couple quick updates.
Co-authored-by: Jeremy Grifski <[email protected]>
Co-authored-by: Jeremy Grifski <[email protected]>
Co-authored-by: Jeremy Grifski <[email protected]>
Updated author.yml file. I think everything is sorted now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! I know I promised we were almost done. This is one last thing.
projects/transpose matrix/index.md
Outdated
|
||
| Description | size1 | size2 | integers | Output | | ||
| - |:-:|:-:|:-:| -:| | ||
| No input | | | | error | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the error message going to say?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally it should be consistent like "Usage: please enter the dimension of the matrix and the serialized matrix"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha yeah updated it see if it works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo! 🍡
Hey, thanks for helping me out so much. It was great working with you :) |
Yeah, I'm going to take another peek at it and see if I can resolve some of those format issues. |
Alright, I think most of these issues are resolved: https://sample-programs.therenegadecoder.com/projects/transpose-matrix/ |
There's still an issue with the title... WHOOPS! |
Yeah everything works now ig |
Articles for transpose matrix.
This is in reference to the PR in TheRenegadeCoder/sample-programs#1952