-
-
Notifications
You must be signed in to change notification settings - Fork 27
Added Josephus Problem in Every Language Article #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is in reference to the enhancement for PR #1933 in TheRenegadeCoder/sample-programs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, really nice work! Just a couple minor changes.
Co-authored-by: Jeremy Grifski <[email protected]>
Co-authored-by: Jeremy Grifski <[email protected]>
Co-authored-by: Jeremy Grifski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I think we can update the dates and we'll be good to go.
Actually, when you say "index", do you mean starting from 1 or starting from 0? That should probably be documented in here. |
Updated date Co-authored-by: Jeremy Grifski <[email protected]>
Updated date Co-authored-by: Jeremy Grifski <[email protected]>
It's starting from 0. Here is a demonstartion of how it works: |
Is there any way you could add this example to the description? I think it would help a lot! |
Shall I add it as an example in the description or shall I make a new example sub heading and add under it? |
Good question! I think we usually put examples as a sub heading under Description. See Bubble Sort: https://sample-programs.therenegadecoder.com/projects/bubble-sort/ |
I have added an example. Kindly check it and let me know if there are any more changes to be made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a quick fix and we're ready to go
Co-authored-by: Jeremy Grifski <[email protected]>
Great!! |
This is in reference to the enhancement for PR in TheRenegadeCoder/sample-programs#1933