-
-
Notifications
You must be signed in to change notification settings - Fork 27
Added Maximum Subarray in Every Language Article #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part. I'm wondering if we could rename this program from Kadane's Algorithm to Maximum Subarrary.
@jrg94 I've renamed the program to Maximum Subarray. Kindly review and merge if it looks good. |
What the heck is going on with all the files changed.... |
Sorry about that. I fixed it @jrg94 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great job so far! We're almost done with the docs. They'll probably need to be reviewed once more before they're ready to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project documentation looks good to me! Just a heads up, we use the command line instead of input()
. So, you'd need to change your code to reference sys.args
. Any chance we could pull your python article out for now?
@jrg94 I've changed input() to sys.argv in the main repository: TheRenegadeCoder/sample-programs#2056 |
Sounds good! The article here will need to be updated as well. |
Updated the docs for sys.args @jrg94 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for being patient with me.
@jrg94 Thanks for merging :) |
Added the docs for implementing Kadane's Algorithm in Python along with explanations for the algorithm, sample input/outputs.
Here is my pending PR in the main repository for the implementation of Kadane's Algorithm in Python:
TheRenegadeCoder/sample-programs#2056
Could you please review it? @jrg94