Skip to content

Added Maximum Subarray in Every Language Article #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 14, 2020

Conversation

Senpai1199
Copy link
Contributor

Added the docs for implementing Kadane's Algorithm in Python along with explanations for the algorithm, sample input/outputs.

Here is my pending PR in the main repository for the implementation of Kadane's Algorithm in Python:
TheRenegadeCoder/sample-programs#2056

Could you please review it? @jrg94

@Senpai1199 Senpai1199 changed the title Add docs for Kadane's Algorithm in Python Add Kadane's Algorithm in Python Article Oct 6, 2020
@Senpai1199 Senpai1199 changed the title Add Kadane's Algorithm in Python Article Added Kadane's Algorithm in Python Article Oct 6, 2020
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part. I'm wondering if we could rename this program from Kadane's Algorithm to Maximum Subarrary.

@jrg94 jrg94 self-assigned this Oct 7, 2020
@jrg94 jrg94 added the project Project documentation label Oct 7, 2020
@Senpai1199
Copy link
Contributor Author

Senpai1199 commented Oct 12, 2020

@jrg94 I've renamed the program to Maximum Subarray. Kindly review and merge if it looks good.
Link to PR for sample-programs repository: TheRenegadeCoder/sample-programs#2056

@jrg94
Copy link
Member

jrg94 commented Oct 12, 2020

What the heck is going on with all the files changed....

@Senpai1199
Copy link
Contributor Author

Sorry about that. I fixed it @jrg94

@jrg94 jrg94 changed the title Added Kadane's Algorithm in Python Article Added Maximum Subarray in Every Language Article Oct 13, 2020
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great job so far! We're almost done with the docs. They'll probably need to be reviewed once more before they're ready to go.

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project documentation looks good to me! Just a heads up, we use the command line instead of input(). So, you'd need to change your code to reference sys.args. Any chance we could pull your python article out for now?

@Senpai1199
Copy link
Contributor Author

@jrg94 I've changed input() to sys.argv in the main repository: TheRenegadeCoder/sample-programs#2056

@jrg94
Copy link
Member

jrg94 commented Oct 13, 2020

Sounds good! The article here will need to be updated as well.

@Senpai1199
Copy link
Contributor Author

Updated the docs for sys.args @jrg94

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for being patient with me.

@jrg94 jrg94 merged commit 4bd5478 into TheRenegadeCoder:master Oct 14, 2020
@Senpai1199
Copy link
Contributor Author

@jrg94 Thanks for merging :)
Here is the PR for the corresponding code for your consideration: TheRenegadeCoder/sample-programs#2056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project Project documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants