Skip to content

Added Palindromic Numbers in Every Language Article #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Oct 7, 2020
Merged

Added Palindromic Numbers in Every Language Article #349

merged 19 commits into from
Oct 7, 2020

Conversation

anohene1
Copy link
Contributor

@anohene1 anohene1 commented Oct 7, 2020

No description provided.

@anohene1 anohene1 mentioned this pull request Oct 7, 2020
Merged
9 tasks
jrg94
jrg94 requested changes Oct 7, 2020
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great stuff! I appreciate you taking the time to do this. Let me know what you think about the comments below.

jrg94
jrg94 requested changes Oct 7, 2020
View reviewed changes
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I think we should stick to integers but change the name of the project to Palindromic Numbers. Also, I still think the output should be true/false. Let me know what you think!

@jrg94 jrg94 self-assigned this Oct 7, 2020
@jrg94 jrg94 added enhancement New feature or request project Project documentation and removed enhancement New feature or request labels Oct 7, 2020
@jrg94 jrg94 changed the title Add articles about Palindrome project and palindrome.kt Added Palindromic Numbers in Every Language Article Oct 7, 2020
@jrg94
Copy link
Member

jrg94 commented Oct 7, 2020

Whenever you finish your changes, we'll be good to merge.

@anohene1
Copy link
Contributor Author

anohene1 commented Oct 7, 2020

I think I've done everything. You may check and let me know if there are other things you'd want me to do.

@jrg94 jrg94 merged commit 2e9d823 into TheRenegadeCoder:master Oct 7, 2020
@anohene1
Copy link
Contributor Author

anohene1 commented Oct 7, 2020

I'm having a little problem renaming the folder to palindrom-number, I will make another pull request if I'm able to figure it out.

@jrg94
Copy link
Member

jrg94 commented Oct 7, 2020

It's fixed I think

@anohene1
Copy link
Contributor Author

anohene1 commented Oct 7, 2020

Sure. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrg94 jrg94 jrg94 requested changes

Assignees

@jrg94 jrg94

Labels
project Project documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anohene1 @jrg94