Skip to content

CompatHelper: bump compat for StatsBase to 0.34, (keep existing compat) #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 2, 2023

This pull request changes the compat entry for the StatsBase package from 0.32, 0.33 to 0.32, 0.33, 0.34.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Closes #418

@devmotion devmotion force-pushed the compathelper/new_version/2023-05-02-00-10-21-822-02329480552 branch from 495b08a to 4586d31 Compare May 2, 2023 00:10
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (be0b04f) 84.61% compared to head (6da765e) 84.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
+ Coverage   84.61%   84.62%   +0.01%     
==========================================
  Files          20       20              
  Lines        1066     1067       +1     
==========================================
+ Hits          902      903       +1     
  Misses        164      164              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yebai
Copy link
Member

yebai commented May 23, 2023

@yebai
Copy link
Member

yebai commented May 23, 2023

Plots.jl is not compatible with [email protected] yet.

@devmotion
Copy link
Member

I bumped JuliaPlots/Plots.jl#4738, hopefully a version with support for StatsBase 0.34 will be available soon.

@yebai yebai merged commit 3251aae into master May 26, 2023
@yebai yebai deleted the compathelper/new_version/2023-05-02-00-10-21-822-02329480552 branch May 26, 2023 12:25
@devmotion devmotion mentioned this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants