1.6.0 CI fails, need to bump minimum version #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
=======================================
Coverage 83.75% 83.75%
=======================================
Files 20 20
Lines 1071 1071
=======================================
Hits 897 897
Misses 174 174 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See e.g. https://github.com/TuringLang/MCMCChains.jl/actions/runs/13531292096/job/37813844525
This is because of JuliaLang/julia#40585 which was fixed in JuliaLang/julia#41645 and backported to 1.6.3
(This wasn't caught previously because we were running CI with the julia version set to
'1.6', which resolves to the latest patch version of 1.6. In #474 I changed the version to'min', which resolves to the earliest possible version specified by the julia compat entry in Project.toml, and then this issue appeared.)