-
Notifications
You must be signed in to change notification settings - Fork 226
Modernise README #2575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Modernise README #2575
Conversation
Turing.jl documentation for PR #2575 is available at: |
b0af4f4
to
7cbd501
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greatly improved, thanks! Some discussion points to raise.
README.md
Outdated
### Discussions | ||
|
||
This repository also has a [Discussions page](https://github.com/TuringLang/Turing.jl/discussions), where you can create discussions and ask questions about statistical applications and theory. | ||
In practice, we don't monitor this as often: you're more likely to get a response through an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced having the discussions enabled really adds much value, and it splits similar information between two places. Would be a shame to lose the old discussions though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that discussions are better opened as issues or Julia discourse.
@mhauru I think there is a GH option to transfer discussions into issues if we want to disable it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to what @mhauru has said. Maybe move some of the below lines up. Push more to use slack for what the discussion handles and issues for anything specifically wrong or needing enhanced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few ways:
-
Leave as is (in which case this text can probably stay)
-
Move all discussions to issues and disable discussions
-
Transfer all discussions to a separate repo and disable discussions
Happy to go with whichever one. Personal preference is (2).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with 1. or 2.
I've also requested reviews from @yebai, for obvious reasons, and from @AoifeHughes, because a new comer's eye can be very valuable here. |
I think lots of the text here can go to: https://github.com/TuringLang/.github/edit/main/profile/README.md We could also keep the pointers for related Turing.jl papers. |
README.md
Outdated
|
||
Turing's home page, with links to everything you'll need to use Turing, is available at: | ||
**https://turinglang.org** contains the documentation for the broader TuringLang ecosystem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be tempted to change the wording to be a bit "friendlier" and less passive voice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions are welcome, I don't know how to make "the docs are here" much friendlier.
README.md
Outdated
### Discussions | ||
|
||
This repository also has a [Discussions page](https://github.com/TuringLang/Turing.jl/discussions), where you can create discussions and ask questions about statistical applications and theory. | ||
In practice, we don't monitor this as often: you're more likely to get a response through an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to what @mhauru has said. Maybe move some of the below lines up. Push more to use slack for what the discussion handles and issues for anything specifically wrong or needing enhanced?
Sure, I was going to work on that too. I think it's worth having info in both though (even if potentially duplicated) because some people will go to github.com/TuringLang and some people will go to github.com/TuringLang/Turing.jl (case in point: if you google for
Will add |
Pull Request Test Coverage Report for Build 15703075136Details
💛 - Coveralls |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2575 +/- ##
==========================================
+ Coverage 85.50% 85.57% +0.06%
==========================================
Files 22 22
Lines 1456 1456
==========================================
+ Hits 1245 1246 +1
+ Misses 211 210 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Personally, I’d still like to see quick start guides be part of readme. Ie just tell me the bash to install, run tests etc. I think forcing people to go off the page to find documentation increases likelihood someone just stops |
Done, there's a super simple example in the readme now, let me know what you think. I refrained from adding tests because Turing's tests take forever to run and the average user isn't likely to ever run them (you have to clone the repo anyway, which is not what most people do unless they're hacking on the package itself) |
See [releases](https://github.com/TuringLang/Turing.jl/releases). | ||
julia> @model function my_first_model(data) | ||
mean ~ Normal(0, 1) | ||
sd ~ Exponential(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HalfCauchy
is a better prior than Exponential
or InverseGamma
. See:
On the Half-Cauchy Prior for a Global Scale Parameter
Nicholas G. Polson, James G. Scott
Bayesian Analysis
link
|
||
### Discussions | ||
|
||
This repository also has a [Discussions page](https://github.com/TuringLang/Turing.jl/discussions), where you can create discussions and ask questions about statistical applications and theory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to remove Discussions in favour of issues / Slack / Julia Discourse.
|
||
- Markov Chain Monte Carlo (both an abstract interface: [AbstractMCMC.jl](https://github.com/TuringLang/AbstractMCMC.jl), and individual samplers, such as [AdvancedMH.jl](https://github.com/TuringLang/AdvancedMH.jl), [AdvancedHMC.jl](https://github.com/TuringLang/AdvancedHMC.jl), and more). | ||
- Variational inference using [AdvancedVI.jl](https://github.com/TuringLang/AdvancedVI.jl). | ||
- Mode estimation techniques, which rely on SciML's [Optimization.jl interface](https://github.com/SciML/Optimization.jl). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Mode estimation techniques, which rely on SciML's [Optimization.jl interface](https://github.com/SciML/Optimization.jl). | |
- Maximum likelihood and maximum a posteriori estimation, which rely on SciML's [Optimization.jl interface](https://github.com/SciML/Optimization.jl). |
|
||
There are also often threads on [Julia Discourse](https://discourse.julialang.org) (you can search using, e.g., [the `turing` tag](https://discourse.julialang.org/tag/turing)). | ||
|
||
We are most active on GitHub, but we do also keep an eye on both Slack and Discourse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this.
We are most active on GitHub, but we do also keep an eye on both Slack and Discourse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few more comments. The prior on the variance / standard deviation parameter is a bit odd and can be improved. Users tend to pay attention to these examples, so staying with best practices is better.
Modernise the README. See the Markdown preview @ https://github.com/TuringLang/Turing.jl/blob/py/readme/README.md
Badges are so 2010s--- I honestly don't think anybody really uses them anymore ever since GitHub Actions took over e.g. travis CI.ReaddedI skipped CI on this PR because this doesn't touch code.
Let me know if there's anything else I should add. Not sure if the last section ('how does it all fit together') should be part of the main docs.