Skip to content

Fix the calculation for the updated belief #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix the calculation for the updated belief #1

wants to merge 1 commit into from

Conversation

rikhuijzer
Copy link
Contributor

The order was reversed as could be seen by computing the posterior distribution for one heads or one tails.
For example, if you calculated the posterior for a sample of size one and containing one heads, the posterior plot would show that the parameter is most likely to be 0 whereas the plot shows that an higher value means a higher probability for heads.

The order was reversed as could be seen by computing the posterior distribution for one heads or one tails.
@cpfiffer
Copy link
Member

This won't fix anything, unfortauntely. Currently the site is not served from this repo, but from TuringLang/Turing.jl.

Tutorials come upstream and any fixes should correct the Jupyter notebooks here: https://github.com/TuringLang/TuringTutorials

@cpfiffer
Copy link
Member

Also this fix doesn't seem to need to be relevant for the main site, since the change is already present there: https://turing.ml/dev/tutorials/0-introduction/

@rikhuijzer
Copy link
Contributor Author

Also this fix doesn't seem to need to be relevant for the main site, since the change is already present there: https://turing.ml/dev/tutorials/0-introduction/

The output on that link has

updated_belief = Beta(prior_belief.α + heads, prior_belief.β + tails)

whereas I propose

updated_belief = Beta(prior_belief.α + tails, prior_belief.β + heads)

I have now proposed this change again at TuringLang/docs#91.

@rikhuijzer rikhuijzer closed this Oct 26, 2020
shravanngoswamii pushed a commit that referenced this pull request Apr 14, 2025
* very basic redesign

* make buttons interactive
shravanngoswamii pushed a commit that referenced this pull request Apr 21, 2025
* very basic redesign

* make buttons interactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants