-
Notifications
You must be signed in to change notification settings - Fork 17
Separate turing.ml site from Turing.jl #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
highest = maximum(highest_tags(versions)) | ||
@info "" baseurl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe @debug instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I'd rather be able to see it in the build logs without setting any other environment variables. It's pretty rare that this would be run by a human.
Seconded - this looks like a sensible separation between docs (Turing.jl and related libraries) and website (appearance, blog, news etc.).
To clarify a bit: does this mean the resulting output is pushed to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work - thanks @cpfiffer! I left two minor questions in the comments section.
Not quite. Both |
* improve colors * better link hover color
* improve colors * better link hover color
This PR makes it so that the build process for
turing.ml
is distinct from Turing.jl. Currently, all the website files live inside Turing'sdocs
folder, which has various disadvantages.Most of the work in the PR shows up in
make.jl
and a little bit inmake-utils.jl
. Everything else is largely copied over fromTuring.jl/docs
. To summarize the new build process:master
of Turing, and then rebuilds whatever the most recent released version is.make.jl
will build the site in a temporary folder and copy all the relevant documents to it. Documenter.jl deploys the docs from this temporary folder.The idea is to keep everything that needs to be "stateful" in Turing.jl, such as the guides and documentation, and everything that always needs to be current (like the blog or list of team members) in this repo. We also don't really want to have much/any HTML in Turing.jl, which this PR also handles. I will remove all the stuff we don't need in Turing once this repo is functional.
Note that this won't actually change the site when the PR goes through, since GitHub is still configured to serve the site from Turing.jl. I assume there will also be some headaches as we transition over, but I won't know until we merge this in.