Support linting + formatting with pre-commit hook #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangchunn
commented
Oct 16, 2018
| "parserOptions": { | ||
| "ecmaVersion": 6, | ||
| "ecmaFeatures": { | ||
| "experimentalObjectRestSpread": true |
There was a problem hiding this comment.
This should be removed once #166 is merged, or the object spread is migrated to Object.assign in index.spec.js#L26 and vue.spec.js#27 due to node6 compat
|
Great work! @piotr-oles are you happy for us to merge this? I think it'll make inconsistent styling a thing of the past; we're using prettier with good results in ts-loader. |
|
I'm going to be bold and assume @piotr-oles is fine with this 😄 |
This was referenced Dec 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enforces linting with
prettier,eslintandtslintfor the project by leveraging pre-commit looks withhuskyandlint-stagedtslint,eslintpackagesprettier,tslint-config-prettier(to disable conflicting rules),husky, andlint-stagedpackagesprettierfor files matchingsrc/**/*.{ts,json}andsrc/**/*.jsfiles onceeslintandtslintstyling rules, like spacing, and semicolons, toprettierwith a pre-commit hook (needs review)yarn lintin CII've tested the pre-commit hooks, and they seem to be working fine.