Skip to content

change order of npm installation#993

Merged
cspotcode merged 1 commit intoTypeStrong:masterfrom
jacobdcastro:jacobdcastro-readme-patch-1
Apr 7, 2020
Merged

change order of npm installation#993
cspotcode merged 1 commit intoTypeStrong:masterfrom
jacobdcastro:jacobdcastro-readme-patch-1

Conversation

@jacobdcastro
Copy link
Copy Markdown

After attempting to copy/paste local installs, I hit an error. ts-node requires a peer dependency of typescript. Therefore, I had to install typescript before ts-node for it successfully install. It makes sense to order these appropriately in the README.

After attempting to copy/paste local installs, I hit an error. ts-node requires a peer dependency of typescript. Therefore, I had to install typescript before ts-node for it to work. It makes sense to order these appropriately in the README.
@cspotcode
Copy link
Copy Markdown
Collaborator

Interesting, I thought yarn was the only one that threw an error when you omit a peerDependency.
Does npm outright disallow this, or merely log a warning?

@jacobdcastro
Copy link
Copy Markdown
Author

It gave me an error outright and didn't install ts-node at all until I installed typecript. I attempted twice with the same result before installing typescript first.

Although, just a minute ago I tried again and worked fine. Possible random glitch earlier.

@cspotcode
Copy link
Copy Markdown
Collaborator

image

@blakeembrey
Copy link
Copy Markdown
Member

Feel free to merge either way, seems like it wouldn't hurt 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants