Skip to content

fix: non-authority player instance spawns with no motion #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: non-authority player instance spawns with no motion #281

wants to merge 1 commit into from

Conversation

NoelStephensUnity
Copy link

Description

Fixes issue where a non-authority player instance could improperly initialize when two clients are connecting to the same session at the "relative" same time. Removing spam logging on collision messages.

Issue Number(s)

Based on NGO user issue #3412

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@NoelStephensUnity
fix
b2e7f73 
Fixes issue where a non-authority player instance could improperly initialize when two clients are connecting to the same session at the "relative" same time.
Removing spam logging on collision messages.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner June 5, 2025 17:30
@NoelStephensUnity NoelStephensUnity mentioned this pull request Jun 5, 2025
Closed
fernando-cortez
fernando-cortez requested changes Jun 18, 2025
View reviewed changes
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- we just have to target develop and add an addition to the changelog!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernando-cortez fernando-cortez fernando-cortez requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelStephensUnity @fernando-cortez