Skip to content

Fix: Removed NetworkObject from Scene State Game Object [MTT-5234] #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

Elfi0Kuhndorf
Copy link
Contributor

Description

I removed the NetworkObject component from the Main Menu Scene State Game Object as it does not need this one. Other scenes do need the NetworkObject for the scene state as far as I can see though. Please confirm if that is the case.

Issue Number(s)

MTT-5234

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@Elfi0Kuhndorf Elfi0Kuhndorf added the 2-Easy This PR is trivial and can be reviewed quickly label Feb 29, 2024
@Elfi0Kuhndorf Elfi0Kuhndorf self-assigned this Feb 29, 2024
@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner February 29, 2024 14:45
@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team February 29, 2024 14:46
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other scenes do need the NetworkObject for the scene state as far as I can see though. Please confirm if that is the case.

Can confirm that's the case!

Though I believe you should be able to just apply the change to the prefab instead, and not have to commit a scene modification.

@fernando-cortez
Copy link
Collaborator

Marking this one too as On Hold until this PR lands.

@fernando-cortez fernando-cortez added the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Mar 1, 2024
@Elfi0Kuhndorf
Copy link
Contributor Author

Elfi0Kuhndorf commented Mar 1, 2024

Other scenes do need the NetworkObject for the scene state as far as I can see though. Please confirm if that is the case.

Can confirm that's the case!

Though I believe you should be able to just apply the change to the prefab instead, and not have to commit a scene modification.

True! I applied the change to the prefab now. What is the best way to remove a file change from a commit? (in this case the MainMenu.unity file)

@fernando-cortez fernando-cortez removed the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Mar 1, 2024
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fernando-cortez fernando-cortez merged commit 3779763 into develop Mar 6, 2024
@fernando-cortez fernando-cortez deleted the fix-network-objects-on-scene-states branch March 6, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-Easy This PR is trivial and can be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants