fix(core): prevent retry of unrecoverable relay errors #7017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDK was retrying all relay errors indefinitely, including unrecoverable errors like JWT validation failures (error code 3000). Changes: - Add isRetryableRelayError() utility to classify errors by code - Update Publisher to check error retryability before queuing retries - Update Subscriber to fail fast on non-retryable errors - Add comprehensive unit tests for error classification Non-retryable error ranges: - 1000-1999: Invalid request errors - 3000-3999: Authentication/Authorization errors (JWT, expired tokens) - 5000-5999: User rejection errors Fixes retry loops on permanent failures while maintaining retry behavior for transient network issues. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the change.
Type of change
How has this been tested?
Only unut tests.
Fixes/Resolves (Optional)
https://linear.app/reown/issue/WK-947/js-sdk-is-retrying-non-retryable-errors
Use this table template to show examples of your changes:
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.