Add keybind for maximizing tiled views

[killown]

No description provided.

[ammen99]

• We also have to be careful, when we have a maximized view, we cannot do any interactive move or resize (as the maximized view covers all the others). So we need to disallow interactive move/resize in these cases. This is same as the fullscreen case, so see the has_fullscreen_view() function, it just needs to have the show_maximized check as well.

• We need to consider what we want to happen when we switch focus. For example say we show_maximized view A, if we switch focus with say alt-tab or use the scale plugin and we focus another view B, what should happen? Do we unmaximize A (this is what happens with fullscreen)? Note that we already have a function to track focus changes, so we could do it like this, when we focus a new view, we check on the current workspace (same principle as has_fullscreen_view) if we can find a view which is shown maximized but is not the new focus. If yes, we unmaximize the view.

• What about the arrow keys, if we navigate to view left/right, do we want an option like for fullscreen, that when we switch to adjacent view, the current one stops being maximized and the next one is maximized? We could leave this as a feature for another PR if you feel it is too much.

[killown]

• We also have to be careful, when we have a maximized view, we cannot do any interactive move or resize (as the maximized view covers all the others). So we need to disallow interactive move/resize in these cases. This is same as the fullscreen case, so see the has_fullscreen_view() function, it just needs to have the show_maximized check as well.

  • We need to consider what we want to happen when we switch focus. For example say we show_maximized view A, if we switch focus with say alt-tab or use the scale plugin and we focus another view B, what should happen? Do we unmaximize A (this is what happens with fullscreen)? Note that we already have a function to track focus changes, so we could do it like this, when we focus a new view, we check on the current workspace (same principle as has_fullscreen_view) if we can find a view which is shown maximized but is not the new focus. If yes, we unmaximize the view.

  • What about the arrow keys, if we navigate to view left/right, do we want an option like for fullscreen, that when we switch to adjacent view, the current one stops being maximized and the next one is maximized? We could leave this as a feature for another PR if you feel it is too much.

• We also have to be careful, when we have a maximized view, we cannot do any interactive move or resize (as the maximized view covers all the others). So we need to disallow interactive move/resize in these cases. This is same as the fullscreen case, so see the has_fullscreen_view() function, it just needs to have the show_maximized check as well.

  • We need to consider what we want to happen when we switch focus. For example say we show_maximized view A, if we switch focus with say alt-tab or use the scale plugin and we focus another view B, what should happen? Do we unmaximize A (this is what happens with fullscreen)? Note that we already have a function to track focus changes, so we could do it like this, when we focus a new view, we check on the current workspace (same principle as has_fullscreen_view) if we can find a view which is shown maximized but is not the new focus. If yes, we unmaximize the view.

  • What about the arrow keys, if we navigate to view left/right, do we want an option like for fullscreen, that when we switch to adjacent view, the current one stops being maximized and the next one is maximized? We could leave this as a feature for another PR if you feel it is too much.

switch to adjacent view, the current one stops being maximized and the next one is maximized? We could leave this as a feature for another PR if you feel it is too much.

Thanks a lot for all recommendations, you might agree that this PR should not be merged before the next wayfire release. As you described possible issues, let it sit for a while then we could implement such features: "switch to adjacent view, the current one stops being maximized and the next one is maximized" .

[ammen99]

looking better, a few more things that I noticed. After these are fixed I think I will start testing the feature as well, to make sure we don't miss anything.

[killown]

output.mp4

[ammen99]

a few more things I saw, gonna test a bit later today