-
Notifications
You must be signed in to change notification settings - Fork 90
Give future.write
flat params (like async imports)
#524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lukewagner
wants to merge
2
commits into
main
Choose a base branch
from
fix-future
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dicej
approved these changes
Jun 4, 2025
dicej
added a commit
to dicej/wasm-tools
that referenced
this pull request
Jun 6, 2025
This implements WebAssembly/component-model#524 insofar as it affects validation, componentization, etc. - `future.write` now accepts its payload value as up to 4 flat parameters before spilling to linear memory. - `future.read` takes no payload pointer when it has no payload type - `{stream,future}.close-{readable,writable}` have been renamed to `{stream,future}.drop-{readable,writable}` Signed-off-by: Joel Dice <[email protected]>
dicej
added a commit
to dicej/wasm-tools
that referenced
this pull request
Jun 6, 2025
This implements WebAssembly/component-model#524 insofar as it affects validation, componentization, etc. - `future.write` now accepts its payload value as up to 4 flat parameters before spilling to linear memory. - `future.read` takes no payload pointer when it has no payload type - `{stream,future}.close-{readable,writable}` have been renamed to `{stream,future}.drop-{readable,writable}` Signed-off-by: Joel Dice <[email protected]>
dicej
added a commit
to dicej/wasm-tools
that referenced
this pull request
Jun 6, 2025
This implements WebAssembly/component-model#524 insofar as it affects validation, componentization, etc. - `future.write` now accepts its payload value as up to 4 flat parameters before spilling to linear memory. - `future.read` takes no payload pointer when it has no payload type - `{stream,future}.close-{readable,writable}` have been renamed to `{stream,future}.drop-{readable,writable}` Signed-off-by: Joel Dice <[email protected]>
dicej
added a commit
to dicej/wasm-tools
that referenced
this pull request
Jun 6, 2025
This implements WebAssembly/component-model#524 insofar as it affects validation, componentization, etc. - `future.write` now accepts its payload value as up to 4 flat parameters before spilling to linear memory. - `future.read` takes no payload pointer when it has no payload type - `{stream,future}.close-{readable,writable}` have been renamed to `{stream,future}.drop-{readable,writable}` Signed-off-by: Joel Dice <[email protected]>
github-merge-queue bot
pushed a commit
to bytecodealliance/wasm-tools
that referenced
this pull request
Jun 6, 2025
* update `future.{write,read}` ABIs This implements WebAssembly/component-model#524 insofar as it affects validation, componentization, etc. - `future.write` now accepts its payload value as up to 4 flat parameters before spilling to linear memory. - `future.read` takes no payload pointer when it has no payload type - `{stream,future}.close-{readable,writable}` have been renamed to `{stream,future}.drop-{readable,writable}` Signed-off-by: Joel Dice <[email protected]> * address CI issues Signed-off-by: Joel Dice <[email protected]> * address review feedback Signed-off-by: Joel Dice <[email protected]> * add WAST tests for various `future.{write,read}` payload sizes Signed-off-by: Joel Dice <[email protected]> * revert lint allow Signed-off-by: Joel Dice <[email protected]> * add test output Signed-off-by: Joel Dice <[email protected]> --------- Signed-off-by: Joel Dice <[email protected]>
dicej
added a commit
to dicej/wit-bindgen
that referenced
this pull request
Jun 6, 2025
This updates the Rust generator to use the new ABI defined in WebAssembly/component-model#524. The C generator will need a similar update as well. - `future.write` now accepts its payload value as up to 4 flat parameters before spilling to linear memory. - `future.read` takes no payload pointer when it has no payload type - `{stream,future}.close-{readable,writable}` have been renamed to `{stream,future}.drop-{readable,writable}` I've tested this end-to-end with `wasip3-prototyping` and will soon post a corresponding PR there. Signed-off-by: Joel Dice <[email protected]>
dicej
added a commit
to dicej/wit-bindgen
that referenced
this pull request
Jun 6, 2025
This updates the Rust generator to use the new ABI defined in WebAssembly/component-model#524. The C generator will need a similar update as well. - `future.write` now accepts its payload value as up to 4 flat parameters before spilling to linear memory. - `future.read` takes no payload pointer when it has no payload type - `{stream,future}.close-{readable,writable}` have been renamed to `{stream,future}.drop-{readable,writable}` I've tested this end-to-end with `wasip3-prototyping` and will soon post a corresponding PR there. Finally, `rustfmt` was complaining about using `gen` as a field name, so I took this opportunity to address that. Signed-off-by: Joel Dice <[email protected]>
dicej
added a commit
to dicej/wit-bindgen
that referenced
this pull request
Jun 6, 2025
This updates the Rust generator to use the new ABI defined in WebAssembly/component-model#524. The C generator will need a similar update as well. - `future.write` now accepts its payload value as up to 4 flat parameters before spilling to linear memory. - `future.read` takes no payload pointer when it has no payload type - `{stream,future}.close-{readable,writable}` have been renamed to `{stream,future}.drop-{readable,writable}` I've tested this end-to-end with `wasip3-prototyping` and will soon post a corresponding PR there. Finally, `rustfmt` was complaining about using `gen` as a field name, so I took this opportunity to address that. Signed-off-by: Joel Dice <[email protected]>
dicej
added a commit
to bytecodealliance/wasip3-prototyping
that referenced
this pull request
Jun 6, 2025
This updates the plumbing, FACT, compilation, and runtime code to use the new ABI defined in WebAssembly/component-model#524. - `future.write` now accepts its payload value as up to 4 flat parameters before spilling to linear memory. - `future.read` takes no payload pointer when it has no payload type - `{stream,future}.close-{readable,writable}` have been renamed to `{stream,future}.drop-{readable,writable}` This commit does _not_ address the following items: > * There is no "number of elements written" packed in the high 28 bits of the `future.{read,write}` results. > * On successful copy, `future.{read,write}` return `COMPLETED` instead of `CLOSED` (which, as noted above, was renamed to `DROPPED`, making it especially "wrong" as the result code). > * When a `future` is "done" (by a `COMPLETED` read/write or by the writable end receiving `DROPPED`), the only valid operation is `future.drop-{readable,writable}`. `future.{read,write}` or lifting traps. > * Because there's no great reason for streams to be more permissive than futures in this regard, streams are also given a "done" state with the same trapping rules as futures, but the stream "done" state is only set when `DROPPED` is received. I'll address those in one or more follow-up commits. Signed-off-by: Joel Dice <[email protected]>
dicej
added a commit
to bytecodealliance/wasip3-prototyping
that referenced
this pull request
Jun 6, 2025
This updates the plumbing, FACT, compilation, and runtime code to use the new ABI defined in WebAssembly/component-model#524. - `future.write` now accepts its payload value as up to 4 flat parameters before spilling to linear memory. - `future.read` takes no payload pointer when it has no payload type - `{stream,future}.close-{readable,writable}` have been renamed to `{stream,future}.drop-{readable,writable}` This commit does _not_ address the following items: > * There is no "number of elements written" packed in the high 28 bits of the `future.{read,write}` results. > * On successful copy, `future.{read,write}` return `COMPLETED` instead of `CLOSED` (which, as noted above, was renamed to `DROPPED`, making it especially "wrong" as the result code). > * When a `future` is "done" (by a `COMPLETED` read/write or by the writable end receiving `DROPPED`), the only valid operation is `future.drop-{readable,writable}`. `future.{read,write}` or lifting traps. > * Because there's no great reason for streams to be more permissive than futures in this regard, streams are also given a "done" state with the same trapping rules as futures, but the stream "done" state is only set when `DROPPED` is received. I'll address those in one or more follow-up commits. Signed-off-by: Joel Dice <[email protected]>
dicej
added a commit
to bytecodealliance/wasip3-prototyping
that referenced
this pull request
Jun 6, 2025
This updates the plumbing, FACT, compilation, and runtime code to use the new ABI defined in WebAssembly/component-model#524. - `future.write` now accepts its payload value as up to 4 flat parameters before spilling to linear memory. - `future.read` takes no payload pointer when it has no payload type - `{stream,future}.close-{readable,writable}` have been renamed to `{stream,future}.drop-{readable,writable}` This commit does _not_ address the following items: > * There is no "number of elements written" packed in the high 28 bits of the `future.{read,write}` results. > * On successful copy, `future.{read,write}` return `COMPLETED` instead of `CLOSED` (which, as noted above, was renamed to `DROPPED`, making it especially "wrong" as the result code). > * When a `future` is "done" (by a `COMPLETED` read/write or by the writable end receiving `DROPPED`), the only valid operation is `future.drop-{readable,writable}`. `future.{read,write}` or lifting traps. > * Because there's no great reason for streams to be more permissive than futures in this regard, streams are also given a "done" state with the same trapping rules as futures, but the stream "done" state is only set when `DROPPED` is received. I'll address those in one or more follow-up commits. Signed-off-by: Joel Dice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a "part 2" of #520, allowing
future.write
to take up toMAX_FLAT_ASYNC_PARAMS
(=4) flat params before resorting to ani32
pointer. For symmetry with async lowering,future.read
is changed to take zero parameters if there is no element type.Working through these changes in the spec highlighted the fact that framing
future
as "astream
that mostly takes 1 element" is too much of a stretch and requires too many hacks that overall add more confusion than simplification. Based on this, this PR decouplesfuture
fromstream
so thatfuture
s make sense on their own. Concretely, this results in the following tweaks to the CABI:{stream,future}.close-{readable,writable}
built-ins are renamed to{stream,future}.drop-{readable,writable}
both for symmetry with {resource.drop
,subtask.drop
} and because "close" is a stream-specific verb. TheCLOSED
result code is accordingly renamedDROPPED
.future.{read,write}
results.future.{read,write}
returnCOMPLETED
instead ofCLOSED
(which, as noted above, was renamed toDROPPED
, making it especially "wrong" as the result code).future
is "done" (by aCOMPLETED
read/write or by the writable end receivingDROPPED
), the only valid operation isfuture.drop-{readable,writable}
.future.{read,write}
or lifting traps.DROPPED
is received.