Skip to content

Conversation

@KYash03
Copy link
Contributor

@KYash03 KYash03 commented Mar 16, 2025

Resolves #14158

Copy link
Member

@nijel nijel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please:

  • Add tests for this new endpoint?
  • Add documentation for this (mention in the changes.rst and add to api.rst).

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (561b199) to head (9a2bb10).
Report is 3185 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14226      +/-   ##
==========================================
+ Coverage   91.01%   91.02%   +0.01%     
==========================================
  Files         610      610              
  Lines       63926    63945      +19     
  Branches     6615     6615              
==========================================
+ Hits        58181    58205      +24     
+ Misses       4035     4030       -5     
  Partials     1710     1710              
Files with missing lines Coverage Δ
weblate/api/tests.py 100.00% <100.00%> (ø)
weblate/api/views.py 89.45% <100.00%> (+0.08%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nijel nijel added this to the 5.11 milestone Mar 17, 2025
@KYash03 KYash03 requested a review from AliceVisek as a code owner March 18, 2025 00:55
@nijel nijel merged commit a22f5f6 into WeblateOrg:main Mar 20, 2025
50 checks passed
@nijel
Copy link
Member

nijel commented Mar 20, 2025

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Groups REST API - Add DELETE /api/groups/(int: id)/roles/(int: role_id)

2 participants