Skip to content

Conversation

@nijel
Copy link
Member

@nijel nijel commented Apr 2, 2025

The compatibility layer introduced in #13640 doesn't gracefully handle when defaults are not passed and leads to crash.

Fixes #14434

The compatibility layer introduced in WeblateOrg#13640 doesn't gracefully handle
when defaults are not passed and leads to crash.

Fixes WeblateOrg#14434
@nijel nijel added this to the 5.11 milestone Apr 2, 2025
@nijel nijel self-assigned this Apr 2, 2025
@nijel nijel enabled auto-merge (rebase) April 2, 2025 06:55
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.05%. Comparing base (1a1e3c8) to head (d187896).
Report is 3248 commits behind head on main.

Files with missing lines Patch % Lines
weblate/auth/models.py 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14435      +/-   ##
==========================================
- Coverage   91.05%   91.05%   -0.01%     
==========================================
  Files         614      614              
  Lines       64147    64150       +3     
  Branches     6640     6641       +1     
==========================================
+ Hits        58409    58410       +1     
- Misses       4023     4025       +2     
  Partials     1715     1715              
Files with missing lines Coverage Δ
weblate/auth/models.py 91.54% <57.14%> (-0.49%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nijel nijel merged commit 2e3ec0e into WeblateOrg:main Apr 2, 2025
47 of 49 checks passed
@nijel nijel deleted the auth-third-party branch April 2, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weblate crashing with remote user authentication after updating to v5.10.4

1 participant