feat: unassigned shortcuts#2737
Open
paxcut wants to merge 2 commits into
Open
Conversation
This PR attempt to address three problems that exist in the current shortcut implementation. 1) If users find themselves having to use some menu item repeatedly they are unable to create a shortcut for it because menu items without shortcuts are not listed in the shortcut setting. 2) Shortcut conflicts leave key sequences in an inconsistent state where the values displayed don't correspond to the actual shortcut key sequence. 3) In order to "recycle" shortcuts used as defaults in ImHex one currently needs to assign some dummy shortcut to the action in question. To address them keys that are not assigned to any key in the keyboard are defined. When these keys are part of a key sequence they make the sequence an unassigned shortcut. When a shortcut collision occurs, it is resolved by turning the shortcut being edited into an unassigned shortcut making its default sequence available to use elsewhere without a dummy.
… Unused function was missing changes if it started to get used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempt to address three problems that exist in the current shortcut implementation.
To address them keys that are not assigned to any key in the keyboard are defined. When these keys are part of a key sequence they make the sequence an unassigned shortcut. When a shortcut collision occurs, it is resolved by turning the shortcut being edited into an unassigned shortcut making its default sequence available to use elsewhere without a dummy.