Skip to content

Write 250 OK in the same syscall as its \r\n #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nabijaczleweli
Copy link

Changes

Two .write() calls means this decoded to sendto("250 OK"); sendto("\r\n"), and the same happened to all the other responses

We don't have writev here but we can just expand line, which works perfectly

Mandatory Checklist

  • Legal agreements accepted. By contributing to this organisation, you acknowledge you have read, understood, and agree to be bound by these these agreements:

Terms of Service, Privacy Policy, Cookie Policy, E-Sign Consent, DMCA, Imprint

Optional Checklist

The following items are optional but might be requested in certain cases.

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Two .write() calls means this decoded to sendto("250 OK"); sendto("\r\n"),
and the same happened to all the other responses

We don't have writev here but we can just expand line, which works perfectly
@adrelanos
Copy link
Contributor

Could you propose this to upstream, original developer of onion-grater, Tails please?

@nabijaczleweli
Copy link
Author

Posted this to tails-dev@ (not in archive yet)

@nabijaczleweli
Copy link
Author

@adrelanos
Copy link
Contributor

Appreciated!

I've edited the readme to point out that this is a fork and patches should be sent to Tails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants