Change the file naming method of the file compare report to avoid duplication of the file compare report file name linked from the folder compare report. #1171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lication of the file compare report file name linked from the folder compare report. - Add the row number in the folder comparison report to the head of the file name in the file comparison report.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rare cases, the file names in the file comparison report linked from the folder comparison report may be duplicated.
It is because "\" in the file path of the comparison item is replaced with "_".
For example, if the folder to be compared contains "AAA\BBB.txt" and "AAA_BBB.txt", the filenames of the two file compare reports are both "AAA_BBB.txt.html".
At this time, the report file of "AAA\BBB.txt" is overwritten by the report of "AAA_BBB.txt" generated later.
As a result, the report "AAA_BBB.txt" is displayed regardless of whether we click "AAA\BBB.txt" or "AAA_BBB.txt" in the folder compare report.
This PR modifies to add the row number of the folder compare report to the head of the file name in the file compare report.
This change makes the file names of the file compare reports unique and avoids duplication.