Skip to content

Make the plugin settings dialog translatable and enable saving settings to an INI file #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Apr 16, 2023

Conversation

sdottaka
Copy link
Member

No description provided.

@@ -383,7 +384,7 @@

m_bMergingMode = GetOptionsMgr()->GetBool(OPT_MERGE_MODE);

m_mainThreadScripts = new CAssureScriptsForThread;
m_mainThreadScripts = new CAssureScriptsForThread(new MergeAppCOMClass());

Check warning

Code scanning / CodeQL

Resource not released in destructor

Resource m_mainThreadScripts is acquired by class CMergeApp but not released in the destructor. It is released from ExitInstance on line 527, so this function may need to be called from the destructor.


template<class T>
class MyDispatch : public T, public IDispatch

Check notice

Code scanning / CodeQL

Undisciplined multiple inheritance

Multiple inheritance should not be used with 1 interfaces, 0 private implementations, 0 protected implementations, and 1 public implementations.
@sdottaka sdottaka changed the title Make plugin settings dialog translatable Make the plugin settings dialog translatable and enable saving settings to an INI file Apr 16, 2023
@sdottaka sdottaka added this to the v2.16.30 milestone Apr 16, 2023
@sdottaka sdottaka marked this pull request as ready for review April 16, 2023 10:57
@sdottaka sdottaka merged commit 4c2c6ba into master Apr 16, 2023
@sdottaka sdottaka deleted the make-plugin-settings-dialog-translatable branch April 16, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant