Skip to content

Add view transitions for WP Admin #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 20, 2025
Merged

Add view transitions for WP Admin #2038

merged 20 commits into from
Jun 20, 2025

Conversation

mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Jun 5, 2025 •
edited
Loading

Summary

Something we discussed and considered during WCEU 2025. We wanted to check if View Transitions are supported in WP Admin. In the last few hours, we made some quick tweaks, and it looks like it's working well. So we’ve gone ahead and opened a PR to add View Transition support in WP Admin and it looks awesome! 🚀

Relevant technical choices

@mukeshpanchal27 mukeshpanchal27 self-assigned this Jun 5, 2025
@mukeshpanchal27 mukeshpanchal27 added [Type] Feature A new feature within an existing module no milestone PRs that do not have a defined milestone for release [Plugin] View Transitions Issues for the View Transitions plugin labels Jun 5, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 67.74%. Comparing base (ff5cc68) to head (78d4e13).
Report is 21 commits behind head on trunk.

Files with missing lines Patch % Lines
plugins/view-transitions/includes/settings.php 0.00% 30 Missing ⚠️
plugins/view-transitions/includes/admin.php 0.00% 8 Missing ⚠️
plugins/view-transitions/hooks.php 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            trunk    #2038      +/-   ##
==========================================
- Coverage   68.03%   67.74%   -0.30%     
==========================================
  Files          92       93       +1     
  Lines        7631     7664      +33     
==========================================
  Hits         5192     5192              
- Misses       2439     2472      +33
Flag Coverage Δ
multisite 67.74% <0.00%> (-0.30%) ⬇️
single 36.86% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

felixarntz
felixarntz reviewed Jun 5, 2025
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 Looks very good, just a few notes on the admin UI.

westonruter
westonruter reviewed Jun 5, 2025
View reviewed changes
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review June 17, 2025 08:34
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: felixarntz <[email protected]>
Co-authored-by: westonruter <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

felixarntz
felixarntz reviewed Jun 17, 2025
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 This looks almost good to go. Just a few last points of feedback.

@mukeshpanchal27
Copy link
Member Author

@felixarntz I’ve addressed the feedback, and it looks ready to merge now. Please take a look when you get a chance. 🙌

felixarntz
felixarntz reviewed Jun 18, 2025
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few additional notes from my UI testing.

felixarntz
felixarntz approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 LGTM, awesome work!

@mukeshpanchal27 mukeshpanchal27 merged commit 26db270 into trunk Jun 20, 2025
17 of 18 checks passed
@mukeshpanchal27 mukeshpanchal27 deleted the add/admin-view-transitions branch June 20, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@westonruter westonruter Awaiting requested review from westonruter

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
no milestone PRs that do not have a defined milestone for release [Plugin] View Transitions Issues for the View Transitions plugin [Type] Feature A new feature within an existing module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mukeshpanchal27 @westonruter @felixarntz