Code block: Remove reliance on recommendedWorkerType #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts the interactive code block to use the new `spawnPHPWorkerThread()` signature committed in WordPress/wordpress-playground#471 The old signature was `spawnPHPWorkerThread(url, workerType, options)` The new signature is `spawnPHPWorkerThread(url, options)` as WASM in ESM WebWorkers is now correctly supported in all major browser.
sejas
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the interactive code block to use the new
spawnPHPWorkerThread()signature committed in WordPress/wordpress-playground#471The old signature was
spawnPHPWorkerThread(url, workerType, options)The new signature is
spawnPHPWorkerThread(url, options)as WASM in ESM WebWorkers is now correctly supported in all major browser.Testing Instructions
nx build interactive-code-blockcd dist/packages/interactive-code-block; wp-now start