Skip to content

Add license.txt #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
duanestorey opened this issue Nov 24, 2024 · 4 comments · Fixed by #2
Closed

Add license.txt #1

duanestorey opened this issue Nov 24, 2024 · 4 comments · Fixed by #2

Comments

@duanestorey
Copy link

duanestorey commented Nov 24, 2024

The GPL requires the original copyright of the code stays in place, even after a fork. Where does this exist? You've clearly taken the ACF Pro plugin and mostly checked it in as-is, after stripping the licensing etc, which is odd considering Automattic is suing a company for basically doing this same thing. It also violates several of the WordPress plugin guidelines, but who cares about those, right?

@freddurst1805
Copy link

At first I saw the intention of SCF as a good opportunity for the community to have a fully functionnal ACF Clone with free pro features developed by the community, but since the SCF has been forked it seems they did nothing in the right direction.
They care only about their own business.

@kraftbj kraftbj changed the title GPL requires the copyright to be left in place Add license.txt Nov 24, 2024
@kraftbj
Copy link
Contributor

kraftbj commented Nov 24, 2024

Thanks @duanestorey. You're right that we need to add a license.txt. The original version that this is being forked from did not have that as best as I can tell. This was pushed up to bring the work into a public repo, even if not 100% ready to go.

@duanestorey
Copy link
Author

duanestorey commented Nov 25, 2024

It's not just that it needs some indication that it's GPL, my understanding is that it needs to credit the original copyright holders (WPE and the original author as well) to be GPL compliant.

You should also be aware that ACF is a registered trademark of WP Engine, and the code you are modifying is littered with references to that:

https://tsdr.uspto.gov/#caseNumber=98321135&caseSearchType=US_APPLICATION&caseType=DEFAULT&searchType=statusSearch

@kraftbj
Copy link
Contributor

kraftbj commented Nov 25, 2024

It's not just that it needs some indication that it's GPL, my understanding is that it needs to credit the original copyright holders (WPE and the original author as well) to be GPL compliant.

Sorry, yes, that's what I meant. The WordPress license.txt is what I meant as an example ( https://github.com/WordPress/WordPress/blob/master/license.txt ) in that it references the previous work in addition to include the GPL license itself.

kraftbj added a commit that referenced this issue Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants