Skip to content

Revert text domain change #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Revert text domain change #101

merged 1 commit into from
Apr 2, 2025

Conversation

pkevan
Copy link
Contributor

@pkevan pkevan commented Apr 2, 2025

In order for the filter to be named correctly (https://developer.wordpress.org/reference/functions/shortcode_atts/), the 3rd parameter should be the shortcode.

In order for the filter to be named correctly (https://developer.wordpress.org/reference/functions/shortcode_atts/), the 3rd parameter should be the shortcode.
@pkevan pkevan added the [Type] Bug Something isn't working label Apr 2, 2025
Copy link
Contributor

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbravobernal cbravobernal merged commit ba24fa8 into trunk Apr 2, 2025
5 checks passed
@kraftbj kraftbj deleted the fix/shortcode-atts branch April 14, 2025 14:26
@kraftbj kraftbj added this to the 6.4.2 milestone Apr 14, 2025
kraftbj pushed a commit that referenced this pull request Apr 14, 2025
In order for the filter to be named correctly (https://developer.wordpress.org/reference/functions/shortcode_atts/), the 3rd parameter should be the shortcode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants