Skip to content

[Website] Allow users to set Playground name before saving and rename saved Playgrounds #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from

Conversation

bgrgicak
Copy link
Collaborator

@bgrgicak bgrgicak commented Jan 10, 2025

Motivation for the change, related issues

Before this PR when saving a Playground a name was automatically generated, but there was no way to change the name.

This PR adds the ability to set the Playground name before saving it and rename the Playground after it's already saved.

Note Some of the PR changes were auto-generated linter changes.

Testing Instructions (or ideally a Blueprint)

  • Checkout this branch
  • Start the dev server npm run dev
  • Go to the Playground manager
  • Click save on a temporary site
  • Click cancel or the x icon and confirm the site wasn't saved
  • Click on save again
  • Change the site name
  • Click save and confirm the site was saved under the name you specified
  • Select a saved site
  • Click on the kebab menu of that site and click Rename
  • Rename the site and confirm the changes are saved
Screenshot 2025-07-17 at 07 54 12 Screenshot 2025-07-17 at 07 54 22

@bgrgicak bgrgicak linked an issue Jun 19, 2025 that may be closed by this pull request
bgrgicak added 2 commits July 17, 2025 06:38
@bgrgicak bgrgicak marked this pull request as ready for review July 17, 2025 05:52
@bgrgicak bgrgicak requested a review from a team as a code owner July 17, 2025 05:52
@bgrgicak bgrgicak requested review from zaerl and fellyph July 17, 2025 05:56
@bgrgicak bgrgicak assigned zaerl and unassigned bgrgicak Jul 18, 2025
@zaerl
Copy link
Collaborator

zaerl commented Jul 21, 2025

@akirk, I'm ping you here to let you know Bero asked me to take care of this. I will take a look at what is happening on these E2Es once I will finish my other tasks.

@adamziel
Copy link
Collaborator

adamziel commented Aug 8, 2025

The test failures here are weird. I've started #2486 to work with a smaller change for easier reviews and debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Ask for a name when Saving Playground
3 participants