[ Vite ] Regroup preserve-*-loaders-imports Vite plugin inside a vite-extension

[mho22]

Motivation for the change, related issues

Based on #2999

Intl dynamic extension added a third file where its import had to be ignored : icu.dat. The pull request created a third preserve-data-loaders-imports Vite plugin. This pull request aims to regroup every preserve-{extension}-loaders-imports into a unique Vite extension.

This pull request is more a suggestion than its ignore-*-imports counterpart.

Implementation details

Regrouping repeatedly copy pasted vite plugins inside a vite extension file named `vite-preserve-loaders-imports.ts.

Testing Instructions

CI - test-built-npm-packages should not fail

[adamziel]

It's not easy to parse just by looking at it, let's document these with examples of paths we're targeting with this expression

[mho22]

done. But I don't know if this became more understandable...

[adamziel]

ditto here

[mho22]

done.

[adamziel]

ditto here

[mho22]

done.

[adamziel]

What would it take to introduce a poka-yoke and throw an error when a rule matches zero specifiers?

[mho22]

We could add a const matchedRules = new Set<PreserveLoadersRule>(); and add a matching rule :

if (rule.regex.test(specifier)) {
	matchedRules.add(rule);
...

And during buildEnd we could throw an error if a rule has not been specified :

buildEnd() {
	if (command !== 'build') return;

	const unusedRules = rules.filter(rule => !matchedRules.has(rule));

	if (unusedRules.length > 0) {
		const details = unusedRules
			.map((rule) => `- ${rule.regex}`)
			.join('\n');

		this.error(
			`vite-preserve-loaders-imports: The following rules did not match any dynamic imports:\n${details}\n\n` +
			`This is likely a misconfiguration or a stale regex.`
		);
	}
},

But I think if some regex were not correct Vite would crash anyway.

[adamziel]

It probably would! Still, having an explicit line of defense is always reassuring – we can stay resilient even if something implicit changes and we never realize. Let's add that buildEnd() logic.

[mho22]

done! Thank you Adam.

[adamziel]

"web/public/php/jspi/php_8_4.js".split('/').slice(-3).join('/')

yields php/jspi/php_8_4.js, not ./web/php/jspi/php_8_4.js. Let's double check all the examples are accurate

[mho22]

This exactly proves why these comments are important 😄. I corrected them and added a "resulting in" paragraph.

Done.