Require explicit spawn handler for process spawning #3008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the PHP.wasm emscripten library would automatically use Node.js child_process.spawn() when running in a Node environment. This implicit behavior made it difficult to control and customize process spawning. This change removes the automatic fallback and requires consumers to explicitly call php.setSpawnHandler() to enable proc_open(), popen(), and similar functions. The CLI now sets up the spawn handler explicitly, making the spawning behavior opt-in rather than implicit.
adamziel
added
[Type] Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensures that PHP.js never implicitly calls
child_process.spawn(). Either it does that through an explicit spawn handler, or it throws an error. I've just spent two hours figuring out why isspawn()being called and it turns out I wasn't attaching the spawn handler correctly. An explicit error message would solve that quickly, andspawnis easy to attach as a spawn handler so let's make that semantics opt-in.Test plan
CI