rename keys::{Secret, Public}

[conradoplg]

Based on #105

Closes #59

Not sure about the names, these were what made sense to me, feel free to suggest other names.

[codecov-commenter]

Codecov Report

Base: 83.76% // Head: 82.78% // Decreases project coverage by -0.97% ⚠️

Coverage data is based on head (7607139) compared to base (66ad232).
Patch coverage: 54.16% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   83.76%   82.78%   -0.98%     
==========================================
  Files          17       17              
  Lines        1287     1313      +26     
==========================================
+ Hits         1078     1087       +9     
- Misses        209      226      +17     

Impacted Files	Coverage Δ
frost-core/src/lib.rs	79.41% <ø> (ø)
frost-core/src/signature.rs	72.09% <ø> (ø)
frost-core/src/signing_key.rs	71.42% <ø> (ø)
frost-p256/src/lib.rs	70.07% <0.00%> (ø)
frost-ristretto255/src/lib.rs	69.60% <0.00%> (ø)
frost-core/src/frost/keys.rs	77.82% <50.00%> (-5.07%)	⬇️
frost-core/src/frost/round1.rs	90.72% <100.00%> (ø)
frost-core/src/frost/round2.rs	70.00% <100.00%> (ø)
frost-core/src/tests.rs	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[dconnolly]

@mergify rebase

[mergify]

rebase

❌ Base branch update has failed

Git reported the following error:

Rebasing (1/4)
error: could not apply 0ec252c... make tests generic
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 0ec252c... make tests generic
CONFLICT (add/add): Merge conflict in frost-core/src/tests/vectors.rs
Auto-merging frost-core/src/tests/vectors.rs
Auto-merging frost-core/src/tests/proptests.rs
CONFLICT (content): Merge conflict in frost-core/src/tests/proptests.rs
Auto-merging frost-core/src/tests.rs
CONFLICT (content): Merge conflict in frost-core/src/tests.rs
Auto-merging frost-core/Cargo.toml
CONFLICT (content): Merge conflict in frost-core/Cargo.toml

err-code: 758C9

[conradoplg]

Conflicts solved

[conradoplg]

@dconnolly your changes look good, is this ready to go?

[dconnolly]

@dconnolly your changes look good, is this ready to go?

Yeah approved; I kept getting in analysis paralysis of trying to name things better, but also correspond accurately to the accepted language around shamir secret sharing, verifiable secret sharing (commitments), verifying shares/keys, etc etc, so might as well just merged for now :P

[conradoplg]

@dconnolly your changes look good, is this ready to go?

Yeah approved; I kept getting in analysis paralysis of trying to name things better, but also correspond accurately to the accepted language around shamir secret sharing, verifiable secret sharing (commitments), verifying shares/keys, etc etc, so might as well just merged for now :P

I can relate, we can have another pass at renaming stuff after we are up to date with the spec 😁