Skip to content

Make modelType's strings in JSON schema #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

mristin
Copy link
Contributor

@mristin mristin commented Apr 8, 2022

We make modelType's strings instead of objects since there is no use
to prepare for extensibility at this point.

Additionally, we have to delete the test data for V3RC01 since RC01
expected the model types to be objects, which makes no sense for V3RC02.

We make `modelType`'s strings instead of objects since there is no use
to prepare for extensibility at this point.

Additionally, we have to delete the test data for V3RC01 since RC01
expected the model types to be objects, which makes no sense for V3RC02.
@mristin mristin merged commit 70232a2 into main Apr 8, 2022
@mristin mristin deleted the mristin/Make-model-types-strings-in-JSON-schema branch April 8, 2022 14:53
mristin added a commit that referenced this pull request Apr 9, 2022
* Render the descriptions with smoke at intermediate (#142)

C#
--
* Represent string constants as literals in C# (#136)
* Fix formatting of multi-line invariants in C# (#137)
* Break lines on invariants in C# (#139)
* Wrap the invariant descriptions in C# (#140)

JSON Schema
-----------
* Make ``modelType``'s strings in JSON schema (#143)

XSD
---
* Write XSD generator (#126)
* Fix interfaces in XSD (#128)
* Fix XSD to use correct environment type (#130)
* Undo escaping of ``\x??`` in XSD (#131)
@mristin mristin mentioned this pull request Apr 9, 2022
mristin added a commit that referenced this pull request Apr 9, 2022
* Render the descriptions with smoke at intermediate (#142)

C#
--
* Represent string constants as literals in C# (#136)
* Fix formatting of multi-line invariants in C# (#137)
* Break lines on invariants in C# (#139)
* Wrap the invariant descriptions in C# (#140)

JSON Schema
-----------
* Make ``modelType``'s strings in JSON schema (#143)

XSD
---
* Write XSD generator (#126)
* Fix interfaces in XSD (#128)
* Fix XSD to use correct environment type (#130)
* Undo escaping of ``\x??`` in XSD (#131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant