Skip to content

downport + transpile scaffolding #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 21, 2025
Merged

downport + transpile scaffolding #6

merged 7 commits into from
May 21, 2025

Conversation

larshp
Copy link
Collaborator

@larshp larshp commented May 21, 2025

#2

larshp added 5 commits May 21, 2025 09:33
wip
wip
wip
@larshp larshp requested a review from Copilot May 21, 2025 07:43
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces changes to support downporting and sets up unit tests for the project. Key changes include:

  • Adding new npm scripts in package.json to run downport, transpile, and tests.
  • Updating abaplint.json with simplified rule configurations.
  • Adding configuration files for downporting (abaplint-downport.jsonc) and transpiling (abap_transpile.jsonc), along with a GitHub Actions workflow for running unit tests.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json New dependency and script definitions to support downport and tests
abaplint.json Converted several rule configurations from detailed objects to booleans
abaplint-downport.jsonc Added configuration for the downport process
abap_transpile.jsonc Added transpile configuration to generate output and tests
.github/workflows/unit-test.yml Added GitHub Actions workflow for running unit tests

"typePools": true,
"withHeaderLine": true
},
"obsolete_statement": true,
Copy link
Preview

Copilot AI May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The change from a detailed configuration object to a simple boolean for the 'obsolete_statement' rule simplifies the configuration, but consider adding an inline comment to clarify the rationale for this change for future maintainers.

Copilot uses AI. Check for mistakes.

"selectOption": "^S_.+$",
"severity": "Error"
},
"selection_screen_naming": true,
Copy link
Preview

Copilot AI May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Converting the 'selection_screen_naming' rule from an object with pattern definitions to a boolean may remove some explicit validation details. If intentional, a comment clarifying this simplification could improve code maintainability.

Copilot uses AI. Check for mistakes.

@larshp larshp changed the title downport + running unit tests downport + transpile scaffolding May 21, 2025
@larshp
Copy link
Collaborator Author

larshp commented May 21, 2025

not active, but wanna get this in before doing some minor ABAP refactoring

@larshp larshp marked this pull request as ready for review May 21, 2025 07:57
fix
Copy link
Contributor

@mbtools mbtools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@larshp larshp merged commit 2d9512c into main May 21, 2025
5 checks passed
@larshp larshp deleted the hvam/dt2105 branch May 21, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants