Upgrade the packaging setup

[webknjaz]

I see that currently setup.py is being used and called directly. This is highly discouraged and is deprecated. See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for more details.

It's quite easy to upgrade it to use PEP 517 with invocations via pypa/pip and pypa/build.

If you're open to improvements, I could try to find some time to contribute some packaging and CI/CD-related PRs.

[abhinavsingh]

@webknjaz Will highly appreciate PR for these, I could learn new things :). I am stuck in classic vanilla setup.py workflows and seemingly things have evolved a lot in this aspect. Thank you 👍

[webknjaz]

Woah! Among other problems, there are no wheels uploaded for the last versions on PyPI (since 2019!)

[webknjaz]

First improvement done: #647.

[webknjaz]

@abhinavsingh I've submitted a number of the linting setup maintainability improvements. The last one includes everything but I thought it would probably be easier/more digestible if the building blocks were their own atomic PRs:

• Add a no-op check job to GHA for branch protection #652
• Add a config for YAMLLint #653
• Add a config for flake8 #654
• Add a config for pylint #655
• Correct spelling mistakes caught by codespell #656
• Organize the linting setup around tox+pre-commit #657

This setup is rather strict but has a lot of excludes in the config because there's a lot of the linting violations that get revealed otherwise. I think it'd make a nice series of "good first issues" for beginner contributors to improve.

[webknjaz]

+1 on top #658

[webknjaz]

@abhinavsingh I wanted to ask you if you have a strong preference to have multiple testing workflows. It feels easier to have the testing jobs in the same workflow because then it's possible to create useful dependencies between them.

Another suggestion would be to make the workflow and job names shorter. Ever since GHA got introduced many projects noticed that big job names don't fit in the UI in multiple places on the website making them rather useless. From this, practice to keep them short emerged. I hope you don't mind if I try to come up with better names.

[webknjaz]

Uncommented another fixer on top: #661

[webknjaz]

And here's two more improvements:

• Migrate the pytest invocation to tox #662
• Add autocancellation of the stale PR GHA jobs #663

I'm starting to hit merge conflicts so I'll pause for some time to give you a chance to get these merged before I add more.

[abhinavsingh]

@webknjaz Yes naming shouldn't be an issue. My original intention here was to surface enough context via job names. Checking on the PRs.

[webknjaz]

Yeah I see that. But currently you repeat the same context in many places. Job names show up right after the workflow names in all of the UIs. Plus adding the project name is not particularly useful since when you look at the CI pages, it's visible what repo they are in.

[webknjaz]

@abhinavsingh here are fixes for the pre-commit.ci env:

• Pre-install mypy deps in pre-commit.ci #666
• Fix the YTT201 flake8 violation #667

[abhinavsingh]

@webknjaz Locally I ran into PyLint socket module related errors. Amazingly, same check passes on GHA (and I guess even for you locally). So am I missing something locally here. There are variety of suggestions on StackOverflow. Any hints here?