Skip to content

Contributing guide #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Contributing guide #753

wants to merge 12 commits into from

Conversation

abhinavsingh
Copy link
Owner

Also

  1. Adds new transparent logo
  2. Removes hardcoded 8899 at few places
  3. Use random port in integration tests.

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #753 (abb12e1) into develop (2b3f0cb) will decrease coverage by 4.49%.
The diff coverage is 100.00%.

❗ Current head abb12e1 differs from pull request most recent head b0a92e1. Consider uploading reports for the commit b0a92e1 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #753      +/-   ##
===========================================
- Coverage    87.87%   83.38%   -4.50%     
===========================================
  Files          124      121       -3     
  Lines         5403     5344      -59     
  Branches       432      432              
===========================================
- Hits          4748     4456     -292     
- Misses         569      795     +226     
- Partials        86       93       +7     
Flag Coverage Δ
pytest 83.32% <100.00%> (-4.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
proxy/__main__.py 100.00% <ø> (ø)
proxy/common/_compat.py 100.00% <ø> (ø)
proxy/common/_version.py 100.00% <ø> (ø)
proxy/common/constants.py 100.00% <ø> (ø)
proxy/common/flag.py 90.90% <ø> (-1.58%) ⬇️
proxy/common/logger.py 83.33% <ø> (-1.29%) ⬇️
proxy/common/pki.py 92.75% <ø> (ø)
proxy/common/plugins.py 96.15% <ø> (-0.08%) ⬇️
proxy/common/types.py 100.00% <ø> (ø)
proxy/common/utils.py 87.90% <ø> (-5.65%) ⬇️
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b3f0cb...b0a92e1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant