Update routeMultiple -> routeMultipleLong for getProperty#122
Open
royalgraphx wants to merge 3 commits intoacidanthera:masterfrom
Open
Update routeMultiple -> routeMultipleLong for getProperty#122royalgraphx wants to merge 3 commits intoacidanthera:masterfrom
royalgraphx wants to merge 3 commits intoacidanthera:masterfrom
Conversation
Collaborator
|
From what I remember, these functions cannot be routed with long patches on older macOS versions due to an incompatible prefix. Did you thoroughly test your changes with older XNU kernels? |
Author
|
I did not, but I can spin up every OS X / macOS version later during the week and report back how things went. My bad, forgot to respond until someone recently asked about this. |
Collaborator
|
Thx, that will help. I am fine to merge this if it is safe or merge the route guarded by OS version check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, this probably was not expected to happen any time soon, or practically ever but I suddenly have the need to wrap/reroute
__ZNK15IORegistryEntry11getPropertyEPKcwhich at the moment, would conflict with WhateverGreen's implementation. I would prefer to not ship a custom WEG that has this line updated to allow multiple plug-ins to wrap/reroute this function. The usage in question is in an IORegistry cleansing module, that reports back to specific Procs with specific details about the system such asmanufacturerwith custom stringApple Inc.and so on.This fixes the following kernel panic when a separate plug-in wishes to reroute the same function:
I've ensured that my own plug-in does not interfere with WEG, and vice-versa. I would prefer to not ship a custom WEG, if possible.